Add integration test utilities to create multiple accounts with balance.#786
Add integration test utilities to create multiple accounts with balance.#786
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new integration-test utility to create multiple funded accounts (with accessible private keys) and refactors existing tests to use it, plus adds direct tests for the new helper.
Changes:
- Add
MakeAccountsWithBalancehelper alongsideMakeAccountWithBalance. - Add integration tests validating
MakeAccountWithBalanceandMakeAccountsWithBalance. - Refactor existing protocol/load tests to use the new helper.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
tests/test_utils.go |
Adds MakeAccountsWithBalance helper and related logic. |
tests/test_utils_test.go |
Adds new integration tests covering the account-funding utilities. |
tests/single_proposer/single_proposer_protocol_test.go |
Refactors account creation/endowment to use the new helper. |
tests/large_transactions/large_transactions_test.go |
Refactors account creation/endowment to use the new helper (but changes funding amount). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
facuMH
left a comment
There was a problem hiding this comment.
Overall looks good. I just have a couple of questions.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
facuMH
left a comment
There was a problem hiding this comment.
Thanks for considering changes. Looks good.
If more changes are requested later consider making long require lines into multi-lines, but it is only a minor style remark since this is only test tooling.
6a9a84b to
96b66c8
Compare
96b66c8 to
9989cbb
Compare
This is a small contribution from uncommitted branches, I have seen the pattern recently in tests and this can come out handy.
The function is located next to
MakeAccountWithBalanceto avoid fragmentation.