Skip to content

Add integration test utilities to create multiple accounts with balance.#786

Merged
LuisPH3 merged 3 commits intomainfrom
luis/integration_tests_multiple_Accounts
Apr 2, 2026
Merged

Add integration test utilities to create multiple accounts with balance.#786
LuisPH3 merged 3 commits intomainfrom
luis/integration_tests_multiple_Accounts

Conversation

@LuisPH3
Copy link
Copy Markdown
Contributor

@LuisPH3 LuisPH3 commented Mar 31, 2026

This is a small contribution from uncommitted branches, I have seen the pattern recently in tests and this can come out handy.
The function is located next to MakeAccountWithBalance to avoid fragmentation.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new integration-test utility to create multiple funded accounts (with accessible private keys) and refactors existing tests to use it, plus adds direct tests for the new helper.

Changes:

  • Add MakeAccountsWithBalance helper alongside MakeAccountWithBalance.
  • Add integration tests validating MakeAccountWithBalance and MakeAccountsWithBalance.
  • Refactor existing protocol/load tests to use the new helper.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
tests/test_utils.go Adds MakeAccountsWithBalance helper and related logic.
tests/test_utils_test.go Adds new integration tests covering the account-funding utilities.
tests/single_proposer/single_proposer_protocol_test.go Refactors account creation/endowment to use the new helper.
tests/large_transactions/large_transactions_test.go Refactors account creation/endowment to use the new helper (but changes funding amount).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@facuMH facuMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I just have a couple of questions.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LuisPH3 LuisPH3 requested a review from facuMH March 31, 2026 11:22
Copy link
Copy Markdown
Contributor

@facuMH facuMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering changes. Looks good.
If more changes are requested later consider making long require lines into multi-lines, but it is only a minor style remark since this is only test tooling.

@LuisPH3 LuisPH3 force-pushed the luis/integration_tests_multiple_Accounts branch from 6a9a84b to 96b66c8 Compare March 31, 2026 14:53
@LuisPH3 LuisPH3 force-pushed the luis/integration_tests_multiple_Accounts branch from 96b66c8 to 9989cbb Compare April 2, 2026 07:44
@LuisPH3 LuisPH3 merged commit d5de93e into main Apr 2, 2026
3 checks passed
@LuisPH3 LuisPH3 deleted the luis/integration_tests_multiple_Accounts branch April 2, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants