Skip to content

Fix/rest return body on create#79

Merged
tcheeric merged 4 commits into
developfrom
fix/rest-return-body-on-create
Sep 14, 2025
Merged

Fix/rest return body on create#79
tcheeric merged 4 commits into
developfrom
fix/rest-return-body-on-create

Conversation

@tcheeric

Copy link
Copy Markdown
Collaborator

Summary

This pull request addresses compilation errors related to @Override annotations in repository interfaces. It also resolves issues preventing POST create operations via Spring Data REST and adds integration tests for these endpoints.

What changed?

  • Removed incorrect @Override save declarations in repository interfaces.
  • Explicitly declared save(...) methods in QuoteRepository and PaymentRepository to enable POST create functionality.
  • Added integration tests using H2 to verify POST create operations for /quote and /payment.

BREAKING

None.

Review focus

  • Verify correctness of repository method declarations.
  • Confirm adequacy and reliability of newly added integration tests.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

erict875 and others added 4 commits September 15, 2025 00:18
…tion to satisfy integration tests and client expectations
- Removed the @OverRide annotation from the save method in both
  PaymentRepository and QuoteRepository to satisfy RepositoryInvoker
  detection in certain setups. This change aligns with the expected
  behavior of Spring Data REST.
@tcheeric tcheeric merged commit 50bbb56 into develop Sep 14, 2025
3 of 4 checks passed
@tcheeric tcheeric deleted the fix/rest-return-body-on-create branch September 14, 2025 23:27
@github-actions

github-actions Bot commented Sep 14, 2025

Copy link
Copy Markdown

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Nullability and data flow problems 🔶 Warning 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant