Release/0.3.1#81
Merged
Merged
Conversation
added 4 commits
September 21, 2025 12:45
- Adds explicit IllegalStateException for unknown/mismatched quoteId\n- Guards against stale or invalid IDs before proceeding
- Ensure pay() uses the exact quoteId returned by createMeltQuote\n- Verify paying with stale/unknown quoteId throws\n- Confirm getRequest returns the original invoice for a quote
- Update parent and module POM versions\n- Add 0.3.1 section to changelog (quoteId checks + tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump project version to 0.3.1. Adds strict quoteId validation in Phoenixd gateway (prevents stale/mismatched IDs) and new unit tests for quoteId consistency across Phoenixd and Dummy
gateways. Updates changelog accordingly.
Related issue: #____
What changed?
BREAKING
None. This release tightens validation but does not change public APIs.
Review focus
Checklist
Build and tests
shows similar failures: