Skip to content

Release/0.3.1#81

Merged
tcheeric merged 4 commits into
developfrom
release/0.3.1
Sep 21, 2025
Merged

Release/0.3.1#81
tcheeric merged 4 commits into
developfrom
release/0.3.1

Conversation

@tcheeric

Copy link
Copy Markdown
Collaborator

Summary

Bump project version to 0.3.1. Adds strict quoteId validation in Phoenixd gateway (prevents stale/mismatched IDs) and new unit tests for quoteId consistency across Phoenixd and Dummy
gateways. Updates changelog accordingly.

Related issue: #____

What changed?

  • Version bump:
    • Parent and all module POMs set to 0.3.1
  • Phoenixd gateway:
    • Reject unknown or mismatched quoteId during pay() to ensure the wallet’s POST /mint/bolt11 quoteId equals the mint’s POST /mint/quote/bolt11 result
  • Tests:
    • Phoenixd: quoteId consistency test; unknown/stale quoteId rejection test
    • Dummy: quoteId consistency test; unknown/stale quoteId rejection test; getRequest matches created invoice test
  • Docs:
    • Changelog: added 0.3.1 section

BREAKING

None. This release tightens validation but does not change public APIs.

Review focus

  • Phoenixd pay() guard logic is correct and does not affect valid flows
  • Tests cover the intended quoteId scenarios and are clear
  • All module POMs reference parent 0.3.1 and jib tags still use ${project.version}
  • Changelog entry wording

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object
  • Description links the issue and explains “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (new tests + changelog)

Build and tests

  • Command: mvn -q verify
  • Note: In some environments (e.g., restricted sandboxes), tests using Mockito Inline can fail due to JVM agent attach restrictions on JDK 21 (Byte Buddy self-attach not allowed). If CI
    shows similar failures:
    • Option A: run with non-inline mock maker for those tests
    • Option B: allow agent attach in CI
    • Option C: temporarily run release build with -DskipTests=true for this PR

erict875 added 4 commits September 21, 2025 12:45
- Adds explicit IllegalStateException for unknown/mismatched quoteId\n- Guards against stale or invalid IDs before proceeding
- Ensure pay() uses the exact quoteId returned by createMeltQuote\n- Verify paying with stale/unknown quoteId throws\n- Confirm getRequest returns the original invoice for a quote
- Update parent and module POM versions\n- Add 0.3.1 section to changelog (quoteId checks + tests)
@tcheeric tcheeric merged commit 3db9da6 into develop Sep 21, 2025
0 of 4 checks passed
@tcheeric tcheeric deleted the release/0.3.1 branch September 21, 2025 11:55
@tcheeric tcheeric restored the release/0.3.1 branch September 22, 2025 21:46
@tcheeric tcheeric deleted the release/0.3.1 branch February 20, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant