scripts: harden slidev docker helpers #22
Conversation
Populate titles in the generated template, allow selecting host ports, and expose NODE_OPTIONS to bump the Playwright container heap. Also ignore crash dumps and temporary vite config files created while rendering. Signed-off-by: Piotr Król <[email protected]>
pietrushnic
force-pushed
the
scripts-improve-docker-helpers
branch
from
b823bf1 to
8f1ba71
Compare
| tmp.* | ||
| slides | ||
| core | ||
| vite.config.ts |
There was a problem hiding this comment.
From what I can see this might ignore:
./theme/vite.config.ts
./vite.config.ts
in the future. Currently git is tracking those files and it keeps doing it even if you add this file to .gitignore. Is this how you want it to behave?
There was a problem hiding this comment.
I'm not sure, I have experience this file keeps showing, maybe it is created or copied by something.
There was a problem hiding this comment.
Then use only file you want to exclude, this pattern will exclude them all which might result in confusion in the future. I'm pretty sure we want ./vite.config.ts (you even edit it in: https://github.com/3mdeb/slidev-template/pull/23/files#diff-6a3b01ba97829c9566ef2d8dc466ffcffb4bdac08706d3d6319e42e0aa6890dd)
|
@pietrushnic The problem is with: @@ -20,3 +20,3 @@
---
-src: slides/pages/zdm_2/04_dts_status.md
+src: ../pages/zdm_2/04_dts_status.md
---It breaks when |
- Replace complex awk title extraction with SLIDES_TITLE env variable - Add comprehensive documentation for all environment variables in help text - Restore symlink creation to fix image rendering and plugin compatibility This addresses all issues raised in PR #22 review. Signed-off-by: Piotr Król <[email protected]>
We should not use relative paths but absolute. I tried to demo that modifying the presentation from ZDM2: zarhus/presentations#22 |
Signed-off-by: Piotr Król <[email protected]>
|
Populate titles in the generated template, allow selecting host ports, and expose NODE_OPTIONS to bump the Playwright container heap. Also ignore crash dumps and temporary vite config files created while rendering.