Skip to content

fix: prevent AF crash when requestedQoS is missing #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ErikGaida wants to merge 4 commits into
base: development
Choose a base branch
from
Open

fix: prevent AF crash when requestedQoS is missing #198

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f75c5d
fix: prevent AF crash when requestedQoS is missing
ErikGaida Jun 12, 2026
0db1f9e
fix: enhance UE connection details population with flow direction han…
ErikGaida Jun 23, 2026
4605813
Update src/5gmsaf/network-assistance-session.c
ErikGaida Jun 23, 2026
fa910f5
Update src/5gmsaf/network-assistance-session.c
ErikGaida Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 38 additions & 26 deletions src/5gmsaf/network-assistance-session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,13 +239,15 @@ void msaf_nw_assistance_session_delivery_boost_update(msaf_network_assistance_se
void msaf_nw_assistance_session_update_pcf_on_timeout(msaf_network_assistance_session_t *na_sess) {

OpenAPI_list_t *media_comps;
char *mir_bw_dl_bit_rate;
char *mir_bw_dl_bit_rate = NULL;
bool rv = false;

ogs_assert(na_sess);

mir_bw_dl_bit_rate = msaf_strdup(na_sess->NetworkAssistanceSession->requested_qo_s->mir_bw_dl_bit_rate);
ogs_assert(mir_bw_dl_bit_rate);
if (!na_sess->NetworkAssistanceSession->requested_qo_s) {
ogs_debug("no requestedQoS: NetworkAssistanceSession.requestedQoS has cardinality [0..1] so mir_bw_dl_bit_rate is NULL");
} else {
mir_bw_dl_bit_rate = msaf_strdup(na_sess->NetworkAssistanceSession->requested_qo_s->mir_bw_dl_bit_rate);
}

media_comps = update_media_component(mir_bw_dl_bit_rate);

Expand Down Expand Up @@ -303,32 +305,36 @@ ue_network_identifier_t *populate_ue_connection_details(msaf_api_service_data_fl
int rv;
ue_network_identifier_t *ue_connection;

ue_connection = ogs_calloc(1, sizeof(ue_network_identifier_t));
ue_connection = ogs_calloc(1, sizeof(*ue_connection));
ogs_assert(ue_connection);

if (service_data_flow_information->domain_name) {
ue_connection->ip_domain = msaf_strdup(service_data_flow_information->domain_name);
}

if (!strcmp(service_data_flow_information->flow_description->direction, "UPLINK")) {

rv = ogs_getaddrinfo(&ue_connection->address, AF_UNSPEC, service_data_flow_information->flow_description->src_ip, service_data_flow_information->flow_description->src_port, 0);
}

if (!strcmp(service_data_flow_information->flow_description->direction, "DOWNLINK")) {
ogs_info("%s: dst_ip", service_data_flow_information->flow_description->dst_ip);
} else {
if (!strcmp(service_data_flow_information->flow_description->direction, "UPLINK")) {
rv = ogs_getaddrinfo(&ue_connection->address, AF_UNSPEC, service_data_flow_information->flow_description->src_ip, service_data_flow_information->flow_description->src_port, 0);
} else if (!strcmp(service_data_flow_information->flow_description->direction, "DOWNLINK") || !strcmp(service_data_flow_information->flow_description->direction, "BIDIRECTIONAL")) {
ogs_info("%s: dst_ip", service_data_flow_information->flow_description->dst_ip);
rv = ogs_getaddrinfo(&ue_connection->address, AF_UNSPEC, service_data_flow_information->flow_description->dst_ip, service_data_flow_information->flow_description->dst_port, 0);
} else {
ogs_error("Flow direction \"%s\" not implemented", service_data_flow_information->flow_description->direction);
ue_connection_details_free(ue_connection);
return NULL;
}

rv = ogs_getaddrinfo(&ue_connection->address, AF_UNSPEC, service_data_flow_information->flow_description->dst_ip, service_data_flow_information->flow_description->dst_port, 0);
if (rv != OGS_OK) {
ogs_error("getaddrinfo failed");
ue_connection_details_free(ue_connection);
return NULL;
}
}

if (rv != OGS_OK) {
ogs_error("getaddrinfo failed");
if (ue_connection->address == NULL) {
ogs_error("Could not get the address for the UE Service Data Flow at reference point M4");
ue_connection_details_free(ue_connection);
return NULL;
}

if (ue_connection->address == NULL)
ogs_error("Could not get the address for the UE connection");

return ue_connection;

}
Expand Down Expand Up @@ -413,7 +419,13 @@ static OpenAPI_list_t *populate_media_component(char *policy_template_id, msaf_a
OpenAPI_map_t *MediaComponentMap = NULL;
OpenAPI_media_component_t *MediaComponent = NULL;
OpenAPI_list_t *media_sub_comp_list = NULL;

char *mar_bw_dl_bit_rate = requested_qos ? requested_qos->mar_bw_dl_bit_rate : NULL;
char *mar_bw_ul_bit_rate = requested_qos ? requested_qos->mar_bw_ul_bit_rate : NULL;
char *min_des_bw_dl_bit_rate = requested_qos ? requested_qos->min_des_bw_dl_bit_rate : NULL;
char *min_des_bw_ul_bit_rate = requested_qos ? requested_qos->min_des_bw_ul_bit_rate : NULL;
char *mir_bw_dl_bit_rate = requested_qos ? requested_qos->mir_bw_dl_bit_rate : NULL;
char *mir_bw_ul_bit_rate = requested_qos ? requested_qos->mir_bw_ul_bit_rate : NULL;

MediaComponentList = OpenAPI_list_create();
ogs_assert(MediaComponentList);

Expand Down Expand Up @@ -466,8 +478,8 @@ static OpenAPI_list_t *populate_media_component(char *policy_template_id, msaf_a

media_sub_comp = OpenAPI_media_sub_component_create(OpenAPI_af_sig_protocol_NULL,
NULL, 0, flow_descs, OpenAPI_flow_status_ENABLED,
requested_qos->mar_bw_dl_bit_rate,
requested_qos->mar_bw_ul_bit_rate,
msaf_strdup(mar_bw_dl_bit_rate),
msaf_strdup(mar_bw_ul_bit_rate),
NULL , OpenAPI_flow_usage_NULL);
ogs_assert(media_sub_comp);

Expand All @@ -481,10 +493,10 @@ static OpenAPI_list_t *populate_media_component(char *policy_template_id, msaf_a

MediaComponent = OpenAPI_media_component_create(NULL, NULL, NULL, false, 0, NULL, NULL,
false, 0, NULL, false, 0.0, false, 0.0, NULL, OpenAPI_flow_status_NULL,
msaf_strdup(requested_qos->mar_bw_dl_bit_rate), msaf_strdup(requested_qos->mar_bw_ul_bit_rate),
msaf_strdup(mar_bw_dl_bit_rate), msaf_strdup(mar_bw_ul_bit_rate),
false, 0, false, 0, NULL, NULL, 0, media_sub_comp_list, media_type,
requested_qos->min_des_bw_dl_bit_rate, requested_qos->min_des_bw_ul_bit_rate,
msaf_strdup(requested_qos->mir_bw_dl_bit_rate), msaf_strdup(requested_qos->mir_bw_ul_bit_rate),
msaf_strdup(min_des_bw_dl_bit_rate), msaf_strdup(min_des_bw_ul_bit_rate),
msaf_strdup(mir_bw_dl_bit_rate), msaf_strdup(mir_bw_ul_bit_rate),
OpenAPI_preemption_capability_NULL, OpenAPI_preemption_vulnerability_NULL,
OpenAPI_priority_sharing_indicator_NULL, OpenAPI_reserv_priority_NULL,
NULL, NULL, false, 0, false, 0, NULL, NULL, NULL, false, 0);
Expand Down