Skip to content

3GPP-Rel18 branch: C++ mustache template fixes#68

Open
davidjwbbc wants to merge 2 commits into
5G-MAG:3GPP-Rel18from
davidjwbbc:3GPP-Rel18
Open

3GPP-Rel18 branch: C++ mustache template fixes#68
davidjwbbc wants to merge 2 commits into
5G-MAG:3GPP-Rel18from
davidjwbbc:3GPP-Rel18

Conversation

@davidjwbbc

Copy link
Copy Markdown
Contributor

This adds some extra handling for composed types to account for the 3GPP definitions of objects used in MBSTF packet operating mode.

This also adds an override for TS29571_CommonData.yaml to merge multiple string patterns into one pattern so that openapi-generator can handle it. It changes some entries that look like:

Object:
  type: string
  allOf:
    - pattern: "<regex1>"
    - pattern: "<regex2>"

...to:

Object:
  type: string
  pattern: "<intersection regex for regex1 and regex2>"

@davidjwbbc davidjwbbc requested review from devbbc and rjb1000 June 22, 2026 15:47
@davidjwbbc davidjwbbc self-assigned this Jun 22, 2026
@davidjwbbc davidjwbbc added the bug Something isn't working label Jun 22, 2026
@davidjwbbc davidjwbbc added the enhancement New feature or request label Jun 22, 2026
@davidjwbbc davidjwbbc moved this to Ready for review in 5MBS: User Services initial release Jun 22, 2026
@rjb1000

rjb1000 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This also adds an override for TS29571_CommonData.yaml to merge multiple string patterns into one pattern so that openapi-generator can handle it.

Was it just too difficult to code that intersection of two regular expressions in the Mustache template, @davidjwbbc?

@davidjwbbc

Copy link
Copy Markdown
Contributor Author

This also adds an override for TS29571_CommonData.yaml to merge multiple string patterns into one pattern so that openapi-generator can handle it.

Was it just too difficult to code that intersection of two regular expressions in the Mustache template, @davidjwbbc?

It's not that it's difficult, in fact it's quite easy, it's more that openapi-generator doesn't present the multiple patterns in the object model it presents to the mustache templates. So there's nothing for the templates to use to generate appropriate code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants