[WIP] Upgrade to Rust 2018 and parser optimizations #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The NATS codec has been broken due to premature optimizations that actually didn't work. I'm thinking of another way to do so. The problem being that the old way of doing things was just reading the buffer by borrowing and copying data all around, creating unreasonable slowness on some cases. Right now it needs to be rewritten IMO since we actually need to make sure we have a correct command to parse before splitting off the buffer and consuming that split in the parser. |
OtaK
force-pushed
the
feature/parser-optimization
branch
from
d1e3b1c to
b37751f
Compare
OtaK
force-pushed
the
feature/parser-optimization
branch
from
b37751f to
0ec3312
Compare
o0Ignition0o
approved these changes
Jan 7, 2019
Co-Authored-By: OtaK <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5