state mutability fix #272
Open
state mutability fix #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0mkara
requested changes
Dec 29, 2022
| const params = params_ === undefined ? [] : params_; | ||
|
|
||
| logger.success("Waiting for confirmation..."); | ||
| const useContract: useContractType = { |
Member
There was a problem hiding this comment.
Do not use variable name useContract as this name is generally used as a hook.
|
|
||
| const settingsGasLimit = (await getConfiguration().get("gasLimit")) as number; | ||
|
|
||
| const value = |
Member
There was a problem hiding this comment.
When we create the input JSON for payable functions create the JSON with a value field. We should get all the necessary parameters from the input `JSON. Also optionally keep this input.
|
|
||
| export const MutableFunctionCall = async ( | ||
| context: ExtensionContext, | ||
| state: string, |
Member
There was a problem hiding this comment.
state param should be renamed to stateMutability.
| getSignedContract, | ||
| } from "../networks"; | ||
|
|
||
| export const MutableFunctionCall = async ( |
Member
There was a problem hiding this comment.
function names should always start with a smallcap letter.
| value: found.value, | ||
| }); | ||
| } | ||
| const params_ = abiItem.inputs?.map((e: any) => e.value); |
Member
There was a problem hiding this comment.
I think the params should be read inside the mutable & immutable call functions as now the params will contain the payable value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.