Conversation
spuun
reviewed
Nov 13, 2025
Contributor
spuun
left a comment
spuun
left a comment
There was a problem hiding this comment.
LGTM, but add some specs? :)
spuun
approved these changes
Nov 13, 2025
Co-authored-by: Jon Börjesson <jon@spuun.se>
Co-authored-by: Jon Börjesson <jon@spuun.se>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Allows the user of this library to specify a max payload size.
The payload for the Publish packet is stored in memory and when running on memory constrained devices this gives the possibility to keep the memory usage low.
WHAT is this pull request doing?
When constructing the
MQTT::IOan optional parameter allows to set the max_packet_size that will be used when reading data from the socket.HOW was this pull request tested?
Pair programming and specs covering this
Co-authored-by: Jon Börjesson jon@84codes.com