Skip to content

Andy's notes on Generalised vertical coordinates #38

Merged
chrisb13 merged 12 commits into
mainfrom
AH-Generalised-Vertical-Coordinates
Jun 15, 2026
Merged

Andy's notes on Generalised vertical coordinates #38
chrisb13 merged 12 commits into
mainfrom
AH-Generalised-Vertical-Coordinates

Conversation

@chrisb13

@chrisb13 chrisb13 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Check links was failing on the generated docs_folder/404.html, where root-relative URLs are not resolvable by Lychee in local file mode. This produced false-positive URL-conversion errors and blocked CI despite unrelated documentation links being valid.

  • Problem scope

    • Link-check failures were concentrated in generated 404.html entries (/., /season1/, /assets/...) rather than source markdown links.
  • Change made

    • Updated documentation/lychee_config.toml to exclude the generated 404 output from path-based scanning.
    • Kept all existing URL-level checks and exclusions intact; only narrowed one noisy generated artifact.
  • Config diff (example)

    exclude_path = [
      "site/fontello",
      ".*/404\\.html$",
    ]

@chrisb13 chrisb13 requested a review from AndyHoggANU June 5, 2026 07:12
Date: 11/06/2026.

Presenter: Andy Hogg (@AndyHoggANU).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndyHoggANU the idea is that you can put notes (if you wish!) here.

We can then review or merge the PR ahead of tomorrow's meeting. (Another option is just to use the PR-preview until you've finalised.)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AndyHoggANU
AndyHoggANU previously approved these changes Jun 13, 2026

@AndyHoggANU AndyHoggANU left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is now ready. Happy for edits through a further PR if I've missed anything.

@angus-g angus-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this sets things up nicely!

Comment thread documentation/docs/pages/season2.md Outdated
Comment thread documentation/docs/pages/season2.md Outdated
Comment thread documentation/docs/pages/season2.md Outdated
Co-authored-by: Angus Gibson <angus@agibson.me>
AndyHoggANU and others added 2 commits June 14, 2026 12:17
Co-authored-by: Angus Gibson <angus@agibson.me>
Co-authored-by: Angus Gibson <angus@agibson.me>
Copilot AI changed the title Andy's notes on Generalised vertical coordinates Exclude generated 404 page from Lychee checks Jun 14, 2026
@chrisb13 chrisb13 changed the title Exclude generated 404 page from Lychee checks Andy's notes on Generalised vertical coordinates Jun 14, 2026
@chrisb13 chrisb13 force-pushed the AH-Generalised-Vertical-Coordinates branch from 0fda350 to f1bd4ae Compare June 15, 2026 02:24
@chrisb13

Copy link
Copy Markdown
Collaborator Author

chrisb13 force-pushed the AH-Generalised-Vertical-Coordinates branch from 0fda350 to f1bd4ae

This was to remove the copilot commits:

d730768
faa2d59
0fda350

Looks like I'll resolve this manually.

@AndyHoggANU has expressed he'd like to have this merged, so will merge now.

@chrisb13 chrisb13 marked this pull request as ready for review June 15, 2026 02:26
@chrisb13 chrisb13 merged commit 2ea5734 into main Jun 15, 2026
6 of 8 checks passed
@chrisb13 chrisb13 deleted the AH-Generalised-Vertical-Coordinates branch June 15, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants