Conversation
Collaborator
Author
|
After the latest commit, I ran https://code.metoffice.gov.uk/trac/roses-u/browser/d/q/8/1/9/trunk?rev=360149 with all ancillaries other than AMIP set to false: This produced the files The logs are in |
There was a problem hiding this comment.
Pull request overview
Adds a new AMIP ancillary-generation entrypoint for ESM1.6 that reads UKESM-produced NetCDF forcings, applies common coordinate fixes, and writes final UM ancillary outputs into the CMIP7 target directory structure.
Changes:
- Added
cmip7_AM_amip_generate.pyto generate AMIP SST/sea-ice ancillaries from UKESM-produced NetCDF inputs. - Introduced
cmip7_ancil_ukesm.pyhelper module for parsing/loading/fixing UKESM ancillary NetCDF cubes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| CMIP7/esm1p6/atmosphere/cmip7_ancil_ukesm.py | New shared helper for UKESM NetCDF ancillary ingestion and coordinate adjustments. |
| CMIP7/esm1p6/atmosphere/amip/cmip7_AM_amip_generate.py | New AMIP generator wiring together parsers, UKESM load/fix, and ancillary save pathing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+45
to
+46
| gregorian=False, | ||
| replace_bounds=True, |
|
|
||
| # Load the CMIP7 datasets | ||
| ukesm_cube = load_cmip7_ukesm(args) | ||
| # Match the ESM1.5 mask |
Comment on lines
+8
to
+13
| def ukesm_parser(): | ||
| parser = ArgumentParser(add_help=False) | ||
| parser.add_argument("--ukesm-ancil-dirpath") | ||
| parser.add_argument("--ukesm-netcdf-filename") | ||
| parser.add_argument("--save-filename") | ||
| return parser |
Collaborator
Author
There was a problem hiding this comment.
Correct. I left the ozone/cmip7_ozone.py code in deliberately, partly because it does not affect AMIP generation, and partly because it might make for a good first refactoring task for Valentina.
Collaborator
Author
|
The checksums have been stable since the run on 2026.06.26. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
See also https://github.com/ACCESS-NRI/CMIP7-Input/tree/scen7-amip
https://github.com/ACCESS-NRI/ancillary-file-science/tree/1-port-cmip7-amip-code-for-esm16-site-nci
https://code.metoffice.gov.uk/trac/roses-u/browser/d/q/8/1/9/cleanup?rev=360148
https://code.metoffice.gov.uk/trac/roses-u/browser/d/q/8/1/9/trunk?rev=360149
This pull request adds the
cmip7_AM_amip_generate.pyPython code for theAM_seaice_ancil_amipandAM_sst_ancil_amiptasks. This code takes the NetCDF files produced by theAM_ukesm_anciland produces the final ancillary files. This code has also been incorporated into the https://github.com/ACCESS-NRI/CMIP7-Input/tree/scen7-amip branch, which includes all changes from https://github.com/ACCESS-NRI/CMIP7-Input/tree/127-n2-and-o3-for-esm16-h-and-vlThe code was tested by running https://code.metoffice.gov.uk/trac/roses-u/browser/d/q/8/1/9/cleanup?rev=360148 which uses the
scne7-ampbranch and produced the filesThe run logs are in
/scratch/tm70/pcl851/cylc-run/u-dq819.cleanup/run10/log/job/1/AM_*_ancil_amip/