Fix validity time attributes#29
Merged
Merged
Conversation
atteggiani
approved these changes
May 20, 2026
atteggiani
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @blimlim for fixing this!
Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28. This PR swaps the change_dump_date.py script to set the validity time using the
t2_(year/month/day)attributes rather thanv1_(year/month/day), which don't exist in the mulefixed_length_header` attribute.Using the updated script to set the date to 18500101 in an ESM1.6 restart, we see that the initial data time and validity times are correctly set: