Update counts for prognostic and tracer variables#32
Merged
Conversation
blimlim
commented
Jun 22, 2026
blimlim
commented
Jun 22, 2026
atteggiani
previously approved these changes
Jun 22, 2026
atteggiani
left a comment
atteggiani
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @blimlim!
The updates look good to me. Tests look great!
MartinDix
reviewed
Jun 25, 2026
Collaborator
Author
|
Thanks @MartinDix and @atteggiani for your reviews! I'll merge this in now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
This PR updates the
um_fields_subset.pyscript, so that it resets the count of prognostic fields and tracer variables recorded in the file headers after the subsetting is performed. The original version of the script performed this step, and it is required as the UM performs some consistency checks with these at the start of a simulation.Any feedback or suggested changes are welcome!