Propagate dtype to final benchmark result#84
Merged
linamy85 merged 1 commit intoAI-Hypercomputer:mainfrom Jan 23, 2026
Merged
Conversation
7f0fbb4 to
7df8f7d
Compare
Collaborator
|
Hi @linamy85 , seems the final report still does not have the data type for gemm_multiple_run. Can you check again? Thank you |
Collaborator
Author
|
Hi @junjieqian , I can see the |
Collaborator
|
Hi @linamy85 thanks for checking this! We actually did not look into the csv file but only from the stdout logs, which does not include the dtype. |
Collaborator
Author
|
@junjieqian To make sure we're aligned, would I feel like for result gathering, it's the easier if we could rely on final tsv file. Though I know it's quite difficult at the moment due to the lack of GCS support. log for single run |
linamy85
added a commit
that referenced
this pull request
Jan 26, 2026
As requested in [another PR](#84 (comment)) for easier result inspection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change propagates
dtypefrom the benchmark function arguments to final reporting results. This impacts benchmarks that were missing such metadata, including: