merge#33
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Commit worker bundle | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
| git add dist/worker.bundle.js | ||
| git commit -m "Build: Update worker bundle [skip ci]" || exit 0 | ||
| git push |
There was a problem hiding this comment.
The new "Commit worker bundle" step unconditionally commits and pushes the generated dist/worker.bundle.js. However this workflow is triggered for both push and pull_request. On PR runs the checkout is a detached ref with a read‑only GITHUB_TOKEN, so git push will fail (“not on a branch” or permission denied) and the whole build will error even when the PR otherwise builds fine. This step needs an if guard so it only runs on writable refs (e.g. github.event_name == 'push') or it should be moved to a separate workflow.
Useful? React with 👍 / 👎.
1 participant
No description provided.