Merged
Conversation
Just simplifies the call site.
ax3l
reviewed
Nov 7, 2025
Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
ax3l
reviewed
Nov 7, 2025
ax3l
reviewed
Nov 8, 2025
`foreach` is not a function, so once 1D was built all EB `.cpp` files were skipped.
ax3l
reviewed
Nov 8, 2025
Comment on lines
+289
to
+295
| Embedded boundary (EB) support in pyAMReX is still minimal. To build pyAMReX with | ||
| EB support, you need to add ``-DAMReX_EB=ON`` to CMake build options. | ||
|
|
||
| .. autofunction:: amrex.space3d.EB2_Build | ||
|
|
||
| .. autoclass:: amrex.space3d.EBFArrayBoxFactory | ||
| :members: |
Member
There was a problem hiding this comment.
Hm, gotta build locally but something broke the autodocs for all types
https://pyamrex.readthedocs.io/en/latest/usage/api.html
Member
There was a problem hiding this comment.
I built locally and the issue is pybind/pybind11-stubgen#275
EBFArrayBoxFactory depends on FabFactory_FArrayBox but pybind11-stubgen does falsly an alphabetical sorting. Hoping this PR gets accepted and unbreaks it, otherwise we need to fork pybind11-stubgen.
Merged
ax3l
added a commit
that referenced
this pull request
Nov 24, 2025
use branch of pybind11-stubgen: #504 (comment) [preview](https://pyamrex--509.org.readthedocs.build/en/509/usage/api.html)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still work in progress. You can build EB and create EBFArrayBoxFactory objects from python.