Skip to content

Conversation

mpipich
Copy link

@mpipich mpipich commented Mar 27, 2019

Hello!
APY\DataGridBundle\Grid\Source\Entity::getFieldName() does not take into account the use of Embeddables

Copy link
Collaborator

@npotier npotier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I think there is a typo in your code

}

$reflectionFields = $this->ormMetadata->getReflectionProperties();
$reflectionProperty = (isset($reflFields[$name])) ? $reflectionFields[$name] : null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello what is this variable $reflFields ? should it be $reflectionFields ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants