Skip to content

fix error handling in build_android_ndk_guide.sh #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

fix error handling in build_android_ndk_guide.sh #814

merged 1 commit into from
Nov 25, 2025

Conversation

@walidbr
Copy link
Collaborator

@walidbr walidbr commented Nov 17, 2025 •
edited
Loading

Added error handling when:

  • ADB have no device attached.
  • Any of the OOB tests fail.

Resolves: COMPMID-8680
Signed-off-by: Walid BEN ROMDHANE [email protected]

@walidbr walidbr requested a review from gunes-arm November 17, 2025 13:30
gunes-arm
gunes-arm requested changes Nov 17, 2025
View reviewed changes
Copy link
Collaborator

@gunes-arm gunes-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title: Return error if there are no device available in build_android_ndk_guide.sh

@walidbr
Copy link
Collaborator Author

walidbr commented Nov 17, 2025 •
edited
Loading

Successful CI run

@walidbr
Copy link
Collaborator Author

walidbr commented Nov 17, 2025

Commit message title: Return error if there are no device available in build_android_ndk_guide.sh

We are doing 2 things ,
Reporting an error on ADB not detected,
Reporting an error on the failing tests, previously we were just printing the test result and moving on.

@gunes-arm
Copy link
Collaborator

gunes-arm commented Nov 17, 2025

Mine was just a suggestion. Feel free to embed those two things in a suitable way into the title and the description.
But, "fix false positive oob test" doesn't make sense externally. This script is essentially a user guide: https://arm-software.github.io/armnn/25.02/md__build_guide_android_n_d_k.html

@gunes-arm
Copy link
Collaborator

gunes-arm commented Nov 17, 2025

Oh you changed it. The PR title and description should change :)

@walidbr walidbr changed the title fix false positive oob test fix error handling in build_android_ndk_guide.sh Nov 18, 2025
@walidbr walidbr requested a review from gunes-arm November 23, 2025 17:31
gunes-arm
gunes-arm reviewed Nov 24, 2025
View reviewed changes
@walidbr
Return error if there are no device available in build_android_ndk_gu…
16cd43e 
…ide.sh

Resolves: COMPMID-8680
Change-Id: Id21cfb991afdd9265ec8e1ddebca8cd9853b44e7
Signed-off-by: Walid BEN ROMDHANE <[email protected]>
@walidbr walidbr merged commit df462cf into main Nov 25, 2025
1 check passed
@walidbr walidbr deleted the COMPMID-8680 branch November 25, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gunes-arm gunes-arm gunes-arm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@walidbr @gunes-arm