Skip to content

feat: add mobile_no field to Payment Entry and update sync logic to fetch phone number from Contact #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
av-dev2 merged 1 commit into from
Jun 12, 2026
Merged

feat: add mobile_no field to Payment Entry and update sync logic to fetch phone number from Contact #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions landms/patches/custom_fields/custom_fields_json/07_payment_entry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[
{
"name": "Payment Entry-plot",
"idx": 97,
"dt": "Payment Entry",
"label": "Plot",
"fieldname": "plot",
Expand All @@ -14,7 +13,6 @@
},
{
"name": "Payment Entry-plot_number",
"idx": 97,
"dt": "Payment Entry",
"label": "Plot Number",
"fieldname": "plot_number",
Expand All @@ -26,7 +24,6 @@
},
{
"name": "Payment Entry-plot_outstanding_amount",
"idx": 97,
"dt": "Payment Entry",
"label": "Plot Outstanding Amount",
"fieldname": "plot_outstanding_amount",
Expand All @@ -35,5 +32,17 @@
"read_only": 1,
"allow_on_submit": 1,
"doctype": "Custom Field"
},
{
"name": "Payment Entry-mobile_no",
"dt": "Payment Entry",
"label": "Mobile No",
"fieldname": "mobile_no",
"insert_after": "contact_email",
"fieldtype": "Data",
"options": "Phone",
"read_only": 1,
"in_preview": 1,
"doctype": "Custom Field"
}
]
4 changes: 4 additions & 0 deletions landms/payment_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ def validate_payment_entry(doc, method=None):
if not doc.get("references"):
return

if doc.contact_person and not doc.mobile_no:
contact_info = frappe.get_cached_value("Contact", doc.contact_person, ["mobile_no", "phone"], as_dict=True)
doc.mobile_no = contact_info.get("mobile_no") or contact_info.get("phone")

normalized_rows = []
seen_invoice_rows: dict[tuple[str, str], dict] = {}

Expand Down