-
Notifications
You must be signed in to change notification settings - Fork 29
multi-select dropdown shows wrong options after selecting first item #3538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe component's initialization logic transitions from the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Deployed to https://pr-3538.aam-digital.net/ |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
I tried to fix this issue, but it seems the root cause is related to
I also found the following open issues related to virtual scroll:
but none of these approaches resolved our problem. then I checked how this works prroperly in single-select mode and noticed that the issue also exists there also |
|
@Abhinegi2 , the issue you linked does seem to resolve it for me! Changed the internal enum display's ngOnInit to ngOnChanges, as suggested in angular/components#16330 |
|
🎉 This PR is included in version 3.68.0-master.13 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…arch text (#3538) fixes #3526 --------- Co-authored-by: Sebastian Leidig <[email protected]>
|
🎉 This PR is included in version 3.68.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
Before you request a manual PR review from someone, please go through all of this list, check the points and mark them checked here.
This helps us reduce the number of review cycles and use the time of our core reviewers more effectively.
ng lint) passesng test) passes⏪ if issues are commented from testing or code review, make changes. Please then re-check every item of the checklist here again.
Remaining TODOs:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.