Fix crash when parsing activesupport's rbi#136
Open
dorner wants to merge 1 commit into
Open
Conversation
Author
|
Hmm... did not realize that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core RBI files are allowed to have multiple overloading
sigdefinitions. For example, this is taken from activesupport's rbi insorbet-typed:Parlour currently can't handle this and straight out crashes with the error:
node after a sig must be a method definitionThis PR fixes it so at least it doesn't crash. It doesn't go further by amalgamating all the
sigstogether into one (e.g. trying to figure out all the possible permutations of parameters and return values). Might be worth documenting this as a known bug.