Fixed the same alignment issues I had in my code. #167
Open
boringcrypto wants to merge 1 commit intoAbdullahAlfaraj:masterfrom
Open
Fixed the same alignment issues I had in my code.
#167boringcrypto wants to merge 1 commit intoAbdullahAlfaraj:masterfrom
boringcrypto wants to merge 1 commit intoAbdullahAlfaraj:masterfrom
Conversation
Didn't test is here, but couldn't find a contact for you, so this may help.
Owner
|
@boringcrypto Doesn't this increase the size of the image by 1 pixel in each direction? is there a reason why you think it could solve the misalignment issues in #130 |
Author
|
I think it's a misalignment on how photoshop reasons about pixels and how JIMP does it. I had those exact issues and used this to fix it. Give it a whirl and it will probably solve that issue for you too. And come say hi in our discord https://discord.gg/JdvPdg2Edd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't test is here, but couldn't find a contact for you, so this may help.
Since we're working on similar things, ping me on discord: BoringCrypto#3523