Fix console error on web and misplaced line in stacked bar chart for animated variant#1193
Open
imalgrab wants to merge 2 commits intoAbhinandan-Kushwaha:masterfrom
Open
Fix console error on web and misplaced line in stacked bar chart for animated variant#1193imalgrab wants to merge 2 commits intoAbhinandan-Kushwaha:masterfrom
imalgrab wants to merge 2 commits intoAbhinandan-Kushwaha:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @Abhinandan-Kushwaha I realised
widthprop is not needed inSvgwhen rendering a line inside stacked bar chart on web.In fact, it only throws an error that is logged on the console:
The
heightis required though to fix #1191,widthcan be removed and inherited from parent.Moreover, the
bottomvalue for web variant only when line is animated had to be readjusted to avoid the exact same issue with misplacement:before.mov
after.mov