AAF adapter: added clip_timecode_offset argument#1029
Closed
timlehr wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Closed
AAF adapter: added clip_timecode_offset argument#1029timlehr wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
clip_timecode_offset argument#1029timlehr wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Added `clip_timecode_offset` as new optional argument. By default, the behaviour is the same as before. However, if the parameter is set to `False`, the global timecode offset will not be added to the clip source range. This allows for easy access to the actual source range used in the clip.
fabal
force-pushed
the
aaf_include_timecode
branch
from
5e49cc5 to
c19aa58
Compare
Collaborator
|
In discussion with @timlehr, @andrewmoore-nz, and others we would like to hold on this PR until Andrew updates his older PR that touches this same code. The current implementation finds timecode for a clip only from a single mob, but should sum the offsets from a chain of mobs instead. Once that is in place, we can re-examine this PR with a better understanding of how timecode for a clip should be retrieved. |
Contributor
Author
Collaborator
|
Closing i n favor of #1063 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #1028
Summarize your change.
AAF adapter: added
clip_timecode_offsetargumentAdded
clip_timecode_offsetas new optional argument. By default, the behaviour is the same as before. However, if the parameter is set toFalse, the track timecode offset will not be added to the clip source range. This allows for easy access to the actual source range used in the clip.Reference associated tests.
test_aaf_adapter.py