-
Notifications
You must be signed in to change notification settings - Fork 309
Export C++ symbols part 2 #1953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Export C++ symbols part 2 #1953
Conversation
Signed-off-by: Darby Johnston <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
+ Coverage 84.11% 85.00% +0.88%
==========================================
Files 198 181 -17
Lines 22241 13074 -9167
Branches 4687 1206 -3481
==========================================
- Hits 18709 11113 -7596
+ Misses 2610 1778 -832
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 115 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Fixes #1919
This is a replacement for PR #1920
These changes are based on the recommendations from @meshula for exporting symbols without using the CMake GenerateExportHeader functionality.
This PR is a WIP, I've just done the minimum amount of exporting to try out the process. With these changes my test app works OK, without them I get this exception as mentioned in the issue:
To do / questions:
using
keyword; can these be exported or do they need to be replaced with function wrappers? (EDIT: It looks like this is not necessary since everything is inline)My test app for reference:
The CMake file: