Initialize Python Imath values #1956
Open
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darby Johnston <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
=======================================
Coverage 85.10% 85.11%
=======================================
Files 181 181
Lines 12768 12774 +6
Branches 1206 1206
=======================================
+ Hits 10866 10872 +6
Misses 1719 1719
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
reinecke
reviewed
Oct 23, 2025
darbyjohnston
commented
Oct 23, 2025
| py::class_<IMATH_NAMESPACE::Box2d>(m, "Box2d", py::module_local()) | ||
| .def(py::init<>()) | ||
| .def(py::init<>([]() { return IMATH_NAMESPACE::Box2d(IMATH_NAMESPACE::V2d(0.0, 0.0)); })) | ||
| .def(py::init<IMATH_NAMESPACE::V2d>()) |
There was a problem hiding this comment.
@reinecke In the meeting today we were wondering if this also needs to be initialized:
.def(py::init<IMATH_NAMESPACE::V2d>())
I believe this is OK as is, since this constructs a Box2d from a V2d. Since the V2d is now initialized to zero with this change, the Box2d will also be initialized to zero:
v = otio.schema.V2d() # initialized to zero
box = otio.schema.Box2d(v) # also initialized to zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initializes Imath values created in Python to 0.0. In C++ the default constructor does not initialize the values which means they could be anything. This is done as an optimization for C++ but is probably not necessary and also unexpected in Python.
For example this was recently causing CI failures: #1955