-
-
Notifications
You must be signed in to change notification settings - Fork 552
Support for Qwen-Image, Qwen-Image-Edit, and Qwen-Image-Edit-Plus #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
4fc9bc6
Added qwen and qwen_e Arch references
Danamir 312ded2
Added nunchaku_load_qwen_diffusion_model method
Danamir 98da072
Added more references to Qwen
Danamir 7c05daa
Corrected model type expected when loading qwen-image model
Danamir 7424517
Added qwen text encoder type
Danamir 8eae9bd
Use filename svdq quantization detection for qwen models
Danamir 3f97aba
Use nunchaku dit loader with qwen svdq quant
Danamir 03fac7a
Corrected Arch.qwen_e detection
Danamir 9256066
Temporary icons for Qwen-Image and Qwen-Image-Edit models
Danamir 5a2bc0d
Added a default case in load checkpoint
Danamir 1d53e2f
filename variable check in Quantization.from_string
Danamir 99fa539
Added support for Qwen-Image-Edit with TextEncodeQwenImageEdit node
Danamir e305386
Lint format corrections
Danamir 329b9ee
Lint format corrections
Danamir 0cda113
Set default Qwen-Image resolutions
Danamir 231c239
Remove unnecessary code
Danamir 14064f6
Added support for Qwen-Image-Edit-Plus, added Arch.qwen_e_p
Danamir e15de77
Allow references images to be added in Qwen-Image-Edit & Qwen-Image-E…
Danamir f4cc49e
Use multiple reference_latent in Arch.qwen_e_p instead of relying on …
Danamir 9bdecda
Use auto cpu offloading in Nunchaku Qwen loader
Danamir 0f59bcc
Refactored encode_text_prompt and apply_edit_conditioning to do the E…
Danamir a776ef4
Typecheck fix.
Danamir 6c11874
Use arch.is_edit check
Danamir db824a0
Typecheck fix.
Danamir 8075756
Typecheck fix.
Danamir 028b764
Typecheck fix.
Danamir ce27c8a
Format fix.
Danamir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this needed? Was there a svdq file that wasn't detected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some logs to find what was the quantization value, and nothing is returned in the model entity ! I had to resort to the filename trick...
I'll try some more debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you're right, the quant field wasn't set by the model detection
Fixed here: Acly/comfyui-tooling-nodes@f555efb