Skip to content

Conversation

@mrienstra
Copy link

@mrienstra mrienstra commented Oct 31, 2025

Currently only the aw-watcher-afk section has a link to the default config values, this PR adds links for all sections.

Additionally:

  • Change aw-server-python to aw-server (to match repo name)
  • Add missing custom_static option to aw-server & aw-server-rust
  • Correction: aw-server-rust has address option, not host like aw-server
  • Add missing exclude_titles option to aw-watcher-window

Important

Add default config links, correct options, and minor additions to configuration.rst and watchers.rst.

  • Configuration Links:
    • Add links to default config values for aw-server, aw-server-rust, aw-client, and aw-watcher-window in configuration.rst.
  • Corrections and Additions:
    • Rename aw-server-python to aw-server in configuration.rst.
    • Add custom_static option to aw-server and aw-server-rust.
    • Correct aw-server-rust to use address instead of host.
    • Add exclude_titles option to aw-watcher-window.
  • Misc:
    • Add anchor for custom visualizations in watchers.rst.

This description was created by Ellipsis for 1ee0145. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 1ee0145 in 1 minute and 4 seconds. Click for details.
  • Reviewed 80 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 8 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/configuration.rst:13
  • Draft comment:
    Renamed 'aw-server-python' to 'aw-server' for consistency with the repo name. Ensure all references are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. src/configuration.rst:20
  • Draft comment:
    Added the 'custom_static' option with a link to custom visualizations. Verify that the anchor 'custom-visualizations' exists in the docs.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. src/configuration.rst:28
  • Draft comment:
    Changed the config key from 'host' to 'address' in the aw-server-rust section. This aligns with the actual implementation.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. src/configuration.rst:31
  • Draft comment:
    Added the 'custom_static' option for aw-server-rust, mirroring the aw-server configuration. Looks consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. src/configuration.rst:41
  • Draft comment:
    Updated the description for 'client.commit_interval' for clarity. The new phrasing is clearer.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
6. src/configuration.rst:57
  • Draft comment:
    Replaced 'exclude_title' with 'exclude_titles' in the aw-watcher-window section. Confirm that this updated key matches the implementation.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
7. src/configuration.rst:60
  • Draft comment:
    Enhanced inline code formatting for macOS strategies (swift, jxa, applescript) for consistency and readability.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
8. src/watchers.rst:85
  • Draft comment:
    Added the '.. _custom-visualizations:' anchor to facilitate linking from configuration docs. Good addition for navigability.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_QwLaPuxCtpxWY7Yy

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant