Skip to content

feat: add v8 and msgpack/ fix tmp gitignore #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add v8 and msgpack/ fix tmp gitignore #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32f8fa
feat: add v8 and msgpack
mhf-ir Oct 5, 2020
a7b91df
fix: docs
mhf-ir Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ node_modules/
.vscode/

# Project
tmp/
/.local/
/media/
/img/
Expand Down
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ This article will mostly focus on the performance aspect and provide a brief ove

To reproduce the benchmark results, follow these steps.

* Install Node.js ( `12.18.3 LTS` is recommended).
* Install Node.js ( `14 LTS` is requirement).
* Install dependencies:

```shell script
Expand Down Expand Up @@ -196,7 +196,7 @@ This is investigated in an additional result section that is found after the mai

### Hardware

The benchmark is done in Node.js v12.16.3 on 64-bit Windows 10, with an Intel i7-4790K 4.00GHz CPU and 16 GB RAM.
The benchmark is done in Node.js v12.16.3 on 64-bit Windows 10, with an Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz and 32 GB RAM(Speed: 2667 MT/s).

## Result (Protocol Buffers)

Expand Down Expand Up @@ -241,7 +241,7 @@ All implementations (`protobuf-js`, `pbf`, `protons`, `google-protobuf`) stayed
This is a ranking of the estimated maximum safe payload limit (measured as JSON) each library was able to process:

1. `pbf`, `mixed`: 372 MB
2. `JSON`: 298 MB
2. `JSON`, `V8`, `MsgPack`: 298 MB
3. `protobuf-js`: 153 MB
4. `google-protobuf`: 98 MB
5. `protons`: 40 MB
Expand All @@ -250,7 +250,7 @@ This is a ranking of the estimated maximum safe payload limit (measured as JSON)

### Negative effects during decoding

| |JSON|JS|Google|Protons|Pbf|mixed
| |JSON, V8, MsgPack|JS|Google|Protons|Pbf|mixed
|---|---|---|---|---|---|---
|Prototype pollution | |x| |x| |x
|Getters/Setters| | | |x| | |
Expand Down
Loading