- 
                Notifications
    
You must be signed in to change notification settings  - Fork 94
 
feat: Object Detection Sample #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            ashikka
  wants to merge
  17
  commits into
  AdobeDocs:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
ashikka:feat/object-detection-plugin-sample
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            feat: Object Detection Sample #58
                    ashikka
  wants to merge
  17
  commits into
  AdobeDocs:main
from
ashikka:feat/object-detection-plugin-sample
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    pklaschka
  
              
              suggested changes
              
                  
                    Dec 10, 2021 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all: Thank you very much for your contribution(/-s)! 😊! Here's my review for this PR:
General review
- Change Request The PR currently includes the Unsplash Plugin Sample. It seems that the object detection branch is based on the Unsplash plugin sample. Since the Unsplash plugin requires further review, I would request that you remove the Unsplash sample plugin from this PR so that we can focus at the PR's topic here and I'll add an additional, dedicated review for the Unsplash Plugin over in #52 to make it easier to understand/read.
 
Code review
- nice to have it might have made sense to extract the highlight boxes to React-based code, i.e., have a state with a model describing where the boxes should be and then use the React-style 
{ boxes.map(box => <div [...] />)}in the JSX to make it a little bit easier to read, but not a big deal 
Functional Review
- Change Request Please add instructions to the 
README.mdon running the server in thebackendfolder - Installed dependencies using 
npm installin both the sample's root and thebackendfolder -> please mention that this has to get run inbackend, as well, in theREADME.md. - Dependency installation was successful
 - Change Request 
backend/package.jsonshould include astartscript to make it easier to run. - Ran 
node .in the backend folder to continue functional test - Ran 
npm run buildin sample's root folder, as perREADME.md=> success - Added plugin using UXP Developer tool
 - Ran plugin in Photoshop
 - Success: Object Detection and result display worked
 - nice to have A button to use the current Photoshop document (instead of an aribitrary file) would be nice to include some "native" functionality, but out of scope for this PR => not affecting review
 
Conclusion
Overall, this looks great and I'm looking forward to merging it. Before we do, please change these three things:
- Remove the 
unsplash-plugin-samplefrom this PR; this gets a dedicated review in #52 - Add a 
startscript runningnode .to thebackend/package.json - Mention installing dependencies for and running the 
backendin the sample's rootREADME.md 
Thank you in advance 🙂
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR closes #55
What does it do?
This photoshop plugin sample is capable of detecting objects and recognizing them in images using 3rd-party APIs.
How to run the project?
Please refer to the README in the project for more information.
Sample Preview
Check out the sample preview here