[management] Code generation: update services and models - #516
[management] Code generation: update services and models#516AdyenAutomationBot wants to merge 1 commit into
Conversation
bc4409a to
2e1f523
Compare
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the latest OpenAPI specification changes into the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a series of auto-generated changes to the management service, primarily updating models and API definitions. The changes include adding new models like AlipayPlusInfo, GivexInfo, SvsInfo, and ValuelinkInfo, and expanding existing models with new fields and payment method types. Documentation has also been updated across several files to improve clarity, fix links, and provide more context. The changes appear to be consistent with an API update. I've pointed out a couple of minor grammatical improvements in the comments for better documentation quality.
| RequestPaymentMethod Request a payment method | ||
|
|
||
| Sends a request to add a new payment method to the merchant account identified in the path. | ||
| Depending the payment method [`type`](https://docs.adyen.com/api-explorer/Management/latest/post/merchants/_merchantId_/paymentMethodSettings#request-type), you may need to send an additional object required for the payment method. |
There was a problem hiding this comment.
There's a minor grammatical error in this comment. For better clarity, it should be "Depending on the payment method...".
| Depending the payment method [`type`](https://docs.adyen.com/api-explorer/Management/latest/post/merchants/_merchantId_/paymentMethodSettings#request-type), you may need to send an additional object required for the payment method. | |
| Depending on the payment method [`type`](https://docs.adyen.com/api-explorer/Management/latest/post/merchants/_merchantId_/paymentMethodSettings#request-type), you may need to send an additional object required for the payment method. |
| UpdatePaymentMethod Update a payment method | ||
|
|
||
| Updates payment method details for the merchant account and the payment method identified in the path. | ||
| Depending the payment method [`type`](https://docs.adyen.com/api-explorer/Management/latest/patch/merchants/_merchantId_/paymentMethodSettings#request-type), you may need to send an additional object required for the payment method. |
There was a problem hiding this comment.
There's a minor grammatical error in this comment. For better clarity, it should be "Depending on the payment method...".
| Depending the payment method [`type`](https://docs.adyen.com/api-explorer/Management/latest/patch/merchants/_merchantId_/paymentMethodSettings#request-type), you may need to send an additional object required for the payment method. | |
| Depending on the payment method [`type`](https://docs.adyen.com/api-explorer/Management/latest/patch/merchants/_merchantId_/paymentMethodSettings#request-type), you may need to send an additional object required for the payment method. |
2e1f523 to
758e1d7
Compare
| // Country Code. | ||
| CountryCode *string `json:"countryCode,omitempty"` | ||
| // Merchant logo (max. size 150kB). Format: Base64-encoded string. | ||
| Logo *string `json:"logo,omitempty"` | ||
| // The city the merchant is doing business in. | ||
| MerchantCity *string `json:"merchantCity,omitempty"` | ||
| // Legal Business Name of the Merchant. | ||
| MerchantLegalName *string `json:"merchantLegalName,omitempty"` | ||
| // Merchant shop url. | ||
| MerchantShopUrl *string `json:"merchantShopUrl,omitempty"` | ||
| // The state/province of the merchant. | ||
| MerchantStateProvince *string `json:"merchantStateProvince,omitempty"` | ||
| // The street address of the merchant. | ||
| MerchantStreetAddress *string `json:"merchantStreetAddress,omitempty"` | ||
| Logo *string `json:"logo,omitempty"` | ||
| TransactionDescription *TransactionDescriptionInfo `json:"transactionDescription,omitempty"` | ||
| // The zip code of the account. | ||
| ZipCode *string `json:"zipCode,omitempty"` |
There was a problem hiding this comment.
The removal of these optional fields caused the removal of many getters/setters that are exported; thus, marking this PR as containing breaking-changes.
1d44786 to
aeb67a5
Compare
aeb67a5 to
600e276
Compare
961108b to
dc9a642
Compare
8f4909b to
28cf5c4
Compare
708f2b5 to
20fc987
Compare
817b467 to
53876e6
Compare
d3366f4 to
9af51f5
Compare
926b2d6 to
ffa37c6
Compare
9f1f401 to
cb38a9f
Compare
1dd11c7 to
72cffd8
Compare
72cffd8 to
edd3b6d
Compare
b987f86 to
c903349
Compare
cccb1b2 to
137d03b
Compare
eef0cb8 to
94bb8e5
Compare
94bb8e5 to
127b846
Compare
127b846 to
4c4f58f
Compare
This PR contains the automated changes for the
managementservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.