Skip to content

Conversation

@dimitriBouteille
Copy link
Contributor

@dimitriBouteille dimitriBouteille commented Aug 28, 2025

Description

The PR add testing refusal reason feature. This feature only available on testing environment and allows you to easily test different cases (declined payment, fraud, blocked card ...).

More information here: https://docs.adyen.com/development-resources/testing/result-codes/?tab=request_using_acquirer_response_code_1_2

The configuration is simple, it is enough to associate each case with a value that comes from information about the order (e.g. Refusal reason value source)

adyen-feature

Tested scenarios

  • Configure the new configuration and set Environment to Test
  • Try place order
  • The payment must be refused and the request to /v71/payments must be contain additionalData.RequestedTestAcquirerResponseCode.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dimitriBouteille, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature that allows developers to simulate various payment refusal scenarios within the Adyen payment module for Magento, specifically in a testing environment. By configuring a "Refusal reason value source" and a "Refusal reason mapping" in the admin panel, users can trigger specific payment refusal codes (e.g., for fraud, declined payments, or blocked cards) based on data from the order, facilitating comprehensive testing of integration failure scenarios.

Highlights

  • New Configuration Section: A new configuration section "Refusal reason" has been added to the Adyen payment settings in the Magento admin panel.
  • Configurable Refusal Reason Source: Users can now define a source from order properties (e.g., shipping last name, customer email) to determine the simulated refusal reason.
  • Customizable Refusal Reason Mapping: A mapping table allows associating specific values from the chosen source to various Adyen refusal reasons (e.g., "Smith" maps to "Fraud").
  • Automated Refusal Reason Injection: When in demo mode, the system will automatically include the configured RequestedTestAcquirerResponseCode in the payment request to Adyen, enabling the simulation of specific payment outcomes.
  • Testing Environment Only: This feature is exclusively available in the testing environment to aid in robust integration testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature for testing payment refusal reasons in a testing environment. The implementation is well-structured, using enums for refusal reasons and order properties, and new configuration options in the Magento admin. The changes include new blocks, helpers, models, and unit tests. I've found a potential bug in the configuration helper that could lead to a TypeError, and some dead code in one of the models. Overall, the feature is well-implemented and the tests provide good coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant