-
Notifications
You must be signed in to change notification settings - Fork 221
Release v9.20.3 #3121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-9
Are you sure you want to change the base?
Release v9.20.3 #3121
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks the official release of version 9.20.3 for the Adyen Magento2 module. The core change involves incrementing the version number across the project's configuration, reflecting the integration of recent updates, specifically those originating from pull request #3120, into this new stable release. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares for the v9.20.3 release by updating the version number in the VERSION and composer.json files. The changes are consistent across both files. I have added one comment regarding a potential maintainability improvement to consider for the future, which is to avoid duplicating the version number across multiple files by establishing a single source of truth.
| "description": "Official Magento2 Plugin to connect to Payment Service Provider Adyen.", | ||
| "type": "magento2-module", | ||
| "version": "9.20.2", | ||
| "version": "9.20.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number is also specified in the root VERSION file. Having the version number defined in multiple places can lead to inconsistencies if one is updated and the other is missed. To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, it would be beneficial to establish a single source of truth for the version number. Since the application reads the version from this file (via Helper\Data::getModuleVersion()), composer.json appears to be the effective source of truth. A release script could be used to automatically generate or update the VERSION file from this one to ensure they remain synchronized.
e9cd5a9 to
7dd409d
Compare
|



Merged pull requests to be released:
Full Changelog: v9.20.2...main-9