-
Notifications
You must be signed in to change notification settings - Fork 221
Release v10.5.1 #3122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release v10.5.1 #3122
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves as a release candidate for version 10.5.1 of the Adyen Magento2 module. Its primary purpose is to update the module's version number and integrate the changes introduced in a prior merged pull request, preparing the codebase for a new stable release. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly increments the version number to 10.5.1 in both composer.json and the VERSION file for the new release. While the change is correct, I've identified a maintainability issue regarding version number duplication. Having the version in two separate files increases the risk of inconsistency. I've added a comment suggesting consolidating the version number into a single source of truth to make future releases more robust.
| "description": "Official Magento2 Plugin to connect to Payment Service Provider Adyen.", | ||
| "type": "magento2-module", | ||
| "version": "10.5.0", | ||
| "version": "10.5.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number is duplicated here and in the VERSION file. This violates the DRY (Don't Repeat Yourself) principle and can lead to inconsistencies if one file is updated but the other is missed during a release.
To improve maintainability, it would be better to have a single source of truth. Since Helper/PlatformInfo.php already reads the version from this file for display in the admin panel, making composer.json the single source of truth seems appropriate. The VERSION file could then be generated from this file during a build/release process, or removed if it's not used by other tools.
2e65b3f to
272198e
Compare
272198e to
cd702c1
Compare
|



Merged pull requests to be released:
Full Changelog: v10.5.0...main