Skip to content

[recurring] Code generation: update services and models#1628

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/recurring
Open

[recurring] Code generation: update services and models#1628
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/recurring

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the recurring service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners February 2, 2026 09:13
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, generated automatically, updates the recurring service by modifying its API endpoint and enhancing the clarity of JSDoc comments for the Amount data type. These changes ensure the service interacts with the correct Adyen environment and provides more precise documentation for its data models.

Highlights

  • API Endpoint Update: The base API path for recurring services in RecurringApi has been updated from pal-test.adyen.com to paltokenization-test.adyen.com.
  • Documentation Clarity: JSDoc comments for the currency and value properties within the Amount class have been refined for better clarity and precision.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated automatically, updates the recurring service API endpoint and model documentation. While the documentation changes in Amount.ts are fine, the endpoint update in RecurringApi.ts introduces critical issues. The corresponding test file has not been updated, which will cause tests to fail. More importantly, the change may break the logic for constructing LIVE environment URLs, potentially causing issues in production. These problems need to be addressed.

export class RecurringApi extends Service {

private readonly API_BASEPATH: string = "https://pal-test.adyen.com/pal/servlet/Recurring/v68";
private readonly API_BASEPATH: string = "https://paltokenization-test.adyen.com/pal/servlet/Recurring/v68";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change updates the API_BASEPATH. However, this has two significant side effects that need to be addressed:

  1. Broken Tests: The test file src/__tests__/recurring.spec.ts uses nock to mock the API endpoint. It's still configured with the old URL (https://pal-test.adyen.com/pal/servlet/Recurring/v68). This will cause the tests for the recurring service to fail. The test mocks need to be updated to use the new base path.

  2. Potential LIVE Environment Issues: The createBaseUrl method in service.ts contains specific logic for pal- URLs to construct the correct LIVE endpoint URL using a liveEndpointUrlPrefix. The new URL with paltokenization- will not match this condition, and will fall back to a default URL transformation which might be incorrect for the LIVE environment. This could lead to production failures. The createBaseUrl method likely needs to be updated to handle this new URL pattern.

Since these issues can break tests and potentially the production environment, they should be addressed before merging.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/recurring branch from bd69534 to ecb1a69 Compare March 6, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant