[recurring] Code generation: update services and models#1628
[recurring] Code generation: update services and models#1628AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
b501175 to
de56397
Compare
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, generated automatically, updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, generated automatically, updates the recurring service API endpoint and model documentation. While the documentation changes in Amount.ts are fine, the endpoint update in RecurringApi.ts introduces critical issues. The corresponding test file has not been updated, which will cause tests to fail. More importantly, the change may break the logic for constructing LIVE environment URLs, potentially causing issues in production. These problems need to be addressed.
| export class RecurringApi extends Service { | ||
|
|
||
| private readonly API_BASEPATH: string = "https://pal-test.adyen.com/pal/servlet/Recurring/v68"; | ||
| private readonly API_BASEPATH: string = "https://paltokenization-test.adyen.com/pal/servlet/Recurring/v68"; |
There was a problem hiding this comment.
This change updates the API_BASEPATH. However, this has two significant side effects that need to be addressed:
-
Broken Tests: The test file
src/__tests__/recurring.spec.tsusesnockto mock the API endpoint. It's still configured with the old URL (https://pal-test.adyen.com/pal/servlet/Recurring/v68). This will cause the tests for the recurring service to fail. The test mocks need to be updated to use the new base path. -
Potential LIVE Environment Issues: The
createBaseUrlmethod inservice.tscontains specific logic forpal-URLs to construct the correct LIVE endpoint URL using aliveEndpointUrlPrefix. The new URL withpaltokenization-will not match this condition, and will fall back to a default URL transformation which might be incorrect for the LIVE environment. This could lead to production failures. ThecreateBaseUrlmethod likely needs to be updated to handle this new URL pattern.
Since these issues can break tests and potentially the production environment, they should be addressed before merging.
de56397 to
9e64afa
Compare
9e64afa to
bd69534
Compare
bd69534 to
ecb1a69
Compare
This PR contains the automated changes for the
recurringservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.