[management] Code generation: update services and models#1629
[management] Code generation: update services and models#1629AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated, updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new models HomeScreenSettings and KioskModeSettings and integrates them into TerminalSettings. The changes appear to be auto-generated and are consistent. My main feedback is that the unit tests for TerminalSettings have not been updated to cover the new properties, which creates a gap in test coverage. I've left a specific comment with a suggestion on how to address this.
| "homeScreen"?: HomeScreenSettings | null; | ||
| "kioskMode"?: KioskModeSettings | null; |
There was a problem hiding this comment.
The new properties homeScreen and kioskMode have been added to TerminalSettings, but the corresponding unit tests in src/__tests__/terminalSettings.spec.ts have not been updated. This leaves the new properties without test coverage.
Please add tests to verify that these properties can be set to null and to instances of their respective types. For example, you could extend the existing test case for null values:
test("should allow properties to be null", () => {
terminalSettings.cardholderReceipt = null;
terminalSettings.connectivity = null;
terminalSettings.gratuities = null;
terminalSettings.hardware = null;
terminalSettings.homeScreen = null; // Add this
terminalSettings.kioskMode = null; // Add this
expect(terminalSettings.cardholderReceipt).toBeNull();
expect(terminalSettings.connectivity).toBeNull();
expect(terminalSettings.gratuities).toBeNull();
expect(terminalSettings.hardware).toBeNull();
expect(terminalSettings.homeScreen).toBeNull(); // Add this
expect(terminalSettings.kioskMode).toBeNull(); // Add this
});Additionally, a new test case should be added to verify setting valid typed values for homeScreen and kioskMode.
8642929 to
5a4637e
Compare
5a4637e to
42bd677
Compare
This PR contains the automated changes for the
managementservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.