Skip to content

[management] Code generation: update services and models#1629

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/management
Open

[management] Code generation: update services and models#1629
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/management

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the management service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners February 2, 2026 09:13
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated, updates the management service's client by introducing new data models. These models, HomeScreenSettings and KioskModeSettings, provide enhanced capabilities for configuring terminal device behavior, specifically related to user interface elements and application management in kiosk mode. The changes integrate these new configurations into the existing TerminalSettings model and ensure proper handling within the generated code.

Highlights

  • New Models Introduced: Two new TypeScript models, HomeScreenSettings and KioskModeSettings, have been added to define specific terminal configurations.
  • Terminal Settings Expansion: The TerminalSettings model has been updated to include optional homeScreen and kioskMode properties, allowing for more detailed configuration of terminal devices.
  • Automated Code Generation Updates: Core generated files like models.ts and objectSerializer.ts have been updated to correctly export, import, and handle the serialization/deserialization of these new settings.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new models HomeScreenSettings and KioskModeSettings and integrates them into TerminalSettings. The changes appear to be auto-generated and are consistent. My main feedback is that the unit tests for TerminalSettings have not been updated to cover the new properties, which creates a gap in test coverage. I've left a specific comment with a suggestion on how to address this.

Comment on lines +45 to +46
"homeScreen"?: HomeScreenSettings | null;
"kioskMode"?: KioskModeSettings | null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new properties homeScreen and kioskMode have been added to TerminalSettings, but the corresponding unit tests in src/__tests__/terminalSettings.spec.ts have not been updated. This leaves the new properties without test coverage.

Please add tests to verify that these properties can be set to null and to instances of their respective types. For example, you could extend the existing test case for null values:

  test("should allow properties to be null", () => {
    terminalSettings.cardholderReceipt = null;
    terminalSettings.connectivity = null;
    terminalSettings.gratuities = null;
    terminalSettings.hardware = null;
    terminalSettings.homeScreen = null; // Add this
    terminalSettings.kioskMode = null; // Add this

    expect(terminalSettings.cardholderReceipt).toBeNull();
    expect(terminalSettings.connectivity).toBeNull();
    expect(terminalSettings.gratuities).toBeNull();
    expect(terminalSettings.hardware).toBeNull();
    expect(terminalSettings.homeScreen).toBeNull(); // Add this
    expect(terminalSettings.kioskMode).toBeNull(); // Add this
  });

Additionally, a new test case should be added to verify setting valid typed values for homeScreen and kioskMode.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/management branch from 8642929 to 5a4637e Compare February 9, 2026 12:30
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/management branch from 5a4637e to 42bd677 Compare March 6, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant