Skip to content

[transferwebhooks] Code generation: update services and models#1630

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/transferwebhooks
Open

[transferwebhooks] Code generation: update services and models#1630
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/transferwebhooks

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the transferwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners February 2, 2026 09:13
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains automated code generation updates for the transferwebhooks service and its associated models. The changes primarily affect the TransferDataTracking type definition, streamlining its internal structure by adjusting how type discrimination and mapping are handled, likely reflecting updates in the underlying OpenAPI specification.

Highlights

  • Type Definition Update for TransferDataTracking: The discriminator property within the TransferDataTrackingClass has been updated to be strictly of type string, removing the undefined possibility. Additionally, the explicit mapping object for this class has been removed and set to undefined.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, which appears to be automatically generated, introduces a critical breaking change in src/typings/transferWebhooks/transferDataTracking.ts. The mapping property, which is essential for deserializing the polymorphic TransferDataTracking type, has been removed. This will lead to runtime errors when processing transfer webhooks. I have added a critical review comment with a code suggestion to restore the necessary mapping. The other change in the file, which makes the discriminator property non-optional, is a positive improvement.

"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData"
};
static readonly mapping: {[index: string]: string} | undefined = undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Removing the mapping object breaks the deserialization of the polymorphic TransferDataTracking type. The ObjectSerializer relies on this mapping to correctly resolve the concrete type (e.g., EstimationTrackingData) from the type discriminator field in the JSON payload. Without this, deserialization will not work as intended, and related functionality will likely fail at runtime. The existing test in src/__tests__/webhooks/transferWebhook.spec.ts would fail because of this change. Please restore the mapping.

Suggested change
static readonly mapping: {[index: string]: string} | undefined = undefined;
static readonly mapping: {[index: string]: string} | undefined = { "confirmation": "ConfirmationTrackingData", "estimation": "EstimationTrackingData", "internalReview": "InternalReviewTrackingData" };

"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData"
};
static readonly mapping: {[index: string]: string} | undefined = undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcatanese Any idea why this would happen?
On the spec I still see the objects

It also seems like it has not been changed in a couple years

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transferwebhooks branch from 5ee217b to 1009216 Compare February 9, 2026 12:30
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transferwebhooks branch from 1009216 to e6215f9 Compare February 16, 2026 13:06
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transferwebhooks branch from e6215f9 to a554eb5 Compare March 6, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants