[transferwebhooks] Code generation: update services and models#1630
[transferwebhooks] Code generation: update services and models#1630AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated code generation updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, which appears to be automatically generated, introduces a critical breaking change in src/typings/transferWebhooks/transferDataTracking.ts. The mapping property, which is essential for deserializing the polymorphic TransferDataTracking type, has been removed. This will lead to runtime errors when processing transfer webhooks. I have added a critical review comment with a code suggestion to restore the necessary mapping. The other change in the file, which makes the discriminator property non-optional, is a positive improvement.
| "estimation": "EstimationTrackingData", | ||
| "internalReview": "InternalReviewTrackingData" | ||
| }; | ||
| static readonly mapping: {[index: string]: string} | undefined = undefined; |
There was a problem hiding this comment.
Removing the mapping object breaks the deserialization of the polymorphic TransferDataTracking type. The ObjectSerializer relies on this mapping to correctly resolve the concrete type (e.g., EstimationTrackingData) from the type discriminator field in the JSON payload. Without this, deserialization will not work as intended, and related functionality will likely fail at runtime. The existing test in src/__tests__/webhooks/transferWebhook.spec.ts would fail because of this change. Please restore the mapping.
| static readonly mapping: {[index: string]: string} | undefined = undefined; | |
| static readonly mapping: {[index: string]: string} | undefined = { "confirmation": "ConfirmationTrackingData", "estimation": "EstimationTrackingData", "internalReview": "InternalReviewTrackingData" }; |
| "estimation": "EstimationTrackingData", | ||
| "internalReview": "InternalReviewTrackingData" | ||
| }; | ||
| static readonly mapping: {[index: string]: string} | undefined = undefined; |
There was a problem hiding this comment.
@gcatanese Any idea why this would happen?
On the spec I still see the objects
It also seems like it has not been changed in a couple years
5ee217b to
1009216
Compare
1009216 to
e6215f9
Compare
e6215f9 to
a554eb5
Compare
This PR contains the automated changes for the
transferwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.