Skip to content

[balanceplatform] Code generation: update services and models#1637

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/balanceplatform
Open

[balanceplatform] Code generation: update services and models#1637
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/balanceplatform

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners February 17, 2026 21:46
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request incorporates automated code generation updates for the balanceplatform service. The primary purpose of these changes is to extend the API functionality by introducing a new method for retrieving tax form summaries for account holders, along with the necessary data models to support this feature. This update ensures the client library remains synchronized with the latest API specifications.

Highlights

  • New API Endpoint: A new endpoint, getTaxFormSummary, has been added to the AccountHoldersApi to retrieve a summary of tax forms for a given account holder.
  • New Models Introduced: Two new models, Summary and TaxFormSummaryResponse, have been added to support the new tax form summary functionality.
  • API Documentation Updates: JSDoc comments for the existing getTaxForm method have been updated for improved clarity and formatting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/services/balancePlatform/accountHoldersApi.ts
    • Added import for TaxFormSummaryResponse.
    • Updated JSDoc comments for getTaxForm parameters for clarity.
    • Introduced new getTaxFormSummary method to retrieve tax form summaries for account holders.
  • src/typings/balancePlatform/models.ts
    • Exported the new Summary model.
    • Exported the new TaxFormSummaryResponse model.
  • src/typings/balancePlatform/objectSerializer.ts
    • Imported Summary and TaxFormSummaryResponse.
    • Registered Summary and TaxFormSummaryResponse in the typeMap for proper serialization/deserialization.
  • src/typings/balancePlatform/summary.ts
    • Created Summary model with legalEntityId and taxYears properties.
  • src/typings/balancePlatform/taxFormSummaryResponse.ts
    • Created TaxFormSummaryResponse model, encapsulating a list of Summary objects.
Activity
  • This pull request was automatically generated by AdyenAutomationBot.
  • The changes reflect recent updates from the adyen-openapi repository, indicating an automated synchronization process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automated changes from an OpenAPI definition, adding a new endpoint and related models for the balanceplatform service. The changes are generally good, but I've identified an opportunity to improve the generated code for the new API method. My feedback focuses on enhancing type safety and simplifying the parameter handling logic to make the code more robust and readable.

* @param formType {@link string } (Required) The type of tax form you want a summary for. Accepted values are **US1099k** and **US1099nec**.
* @return {@link TaxFormSummaryResponse }
*/
public async getTaxFormSummary(id: string, formType: string, requestOptions?: IRequest.Options): Promise<TaxFormSummaryResponse> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better type safety and to align with the JSDoc, which states accepted values are US1099k and US1099nec, the formType parameter should be typed as a string literal union instead of a generic string. This is consistent with other methods in this API, like getTaxForm.

Suggested change
public async getTaxFormSummary(id: string, formType: string, requestOptions?: IRequest.Options): Promise<TaxFormSummaryResponse> {
public async getTaxFormSummary(id: string, formType: "US1099k" | "US1099nec", requestOptions?: IRequest.Options): Promise<TaxFormSummaryResponse> {

Comment on lines +171 to +176
const hasDefinedQueryParams = formType;
if(hasDefinedQueryParams) {
if(!requestOptions) requestOptions = {};
if(!requestOptions.params) requestOptions.params = {};
if(formType) requestOptions.params["formType"] = formType;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block for handling query parameters is verbose and contains redundant checks. Since formType is a required parameter, it will always have a value. The logic can be simplified to be more direct and readable by using modern TypeScript features and promoting immutability.

        requestOptions = {
            ...requestOptions,
            params: {
                ...requestOptions?.params,
                formType,
            },
        };

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from d9ecda1 to b0ec800 Compare March 6, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant