Skip to content

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Sep 10, 2022

@Dushistov @flxo could you please take a look at the dual licensing and say if you're ok with it?
I've kept the copyright to MIT & Apache and Apache-2.0 is the default license for contributing to the crate.

@elpiel elpiel requested a review from Dushistov September 10, 2022 16:06
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #52 (bfcca9d) into main (260323f) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   82.89%   82.64%   -0.26%     
==========================================
  Files          15       15              
  Lines        1269     1268       -1     
==========================================
- Hits         1052     1048       -4     
- Misses        217      220       +3     
Impacted Files Coverage Δ
src/lib.rs 66.82% <0.00%> (-0.80%) ⬇️
src/sentences/gsa.rs 91.13% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@flxo flxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elpiel elpiel linked an issue Sep 12, 2022 that may be closed by this pull request
2 tasks
@elpiel elpiel linked an issue Oct 20, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supporting additional sentences README update - Contributing & dual license

2 participants