chore(PageVersion): Use instance methods of Publishable#3853
Open
chore(PageVersion): Use instance methods of Publishable#3853
Conversation
The Publishable concern provides the same instance methods, but with a slightly different signature. Since these methods are identical and only used internally we can remove them.
tvdeyen
force-pushed
the
page-version-use-publishable
branch
from
2e60c07 to
c402e58
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3853 +/- ##
==========================================
- Coverage 98.06% 98.06% -0.01%
==========================================
Files 322 322
Lines 8530 8524 -6
==========================================
- Hits 8365 8359 -6
Misses 165 165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The Publishable concern provides the same instance methods, but with a slightly different signature. Since these methods are identical and only used internally we can remove them.
Checklist