Skip to content

clean up types#1612

Draft
davidsmejia wants to merge 2 commits intodevfrom
davidsmejia/clean-up-types
Draft

clean up types#1612
davidsmejia wants to merge 2 commits intodevfrom
davidsmejia/clean-up-types

Conversation

@davidsmejia
Copy link
Contributor

Issue Number

N/A

Purpose/Implementation Notes

Some things have been bothering me while working on this project. So I wanted to take a little bit of time and clean things up. Mostly, I want to resolve any lsp warnings / errors that don't seem to have any impact on our repo. I don't think we should submit this until development has slowed down since lots of stuff is subject to be tweaked in the next couple of weeks. This PR is just to remind me that I started this.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • Refactor (addresses code organization and design mentioned in corresponding issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

List out the functional tests you've completed to verify your changes work locally.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Please attach any screenshots that illustrate these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments