Skip to content

Merge feature/dataset-abc into dev#1783

Draft
avrohomgottlieb wants to merge 53 commits intodevfrom
feature/dataset-abc
Draft

Merge feature/dataset-abc into dev#1783
avrohomgottlieb wants to merge 53 commits intodevfrom
feature/dataset-abc

Conversation

@avrohomgottlieb
Copy link
Contributor

@avrohomgottlieb avrohomgottlieb commented Jan 30, 2026

Issue Number

N/A

Purpose/Implementation Notes

Describe the big picture of your changes.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • Refactor (addresses code organization and design mentioned in corresponding issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

List out the functional tests you've completed to verify your changes work locally.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Please attach any screenshots that illustrate these changes.

@avrohomgottlieb
add DatasetABC CCDLDataset and UserDataset models with their attrs
5708fa4
@avrohomgottlieb
add ccdl logic to ccdldataset model
f9a7967
@avrohomgottlieb
add user logic to userdataset model
e96040f
@avrohomgottlieb
add common dataset logic to datasetabc model
e657f7d
@avrohomgottlieb
update reference names on abc to follow django conventions
1ef1550
@avrohomgottlieb
add migration for user dataset and ccdl dataset classes
e111b4e
@avrohomgottlieb
add ccdl and user dataset attrs to job model
80189f1
@avrohomgottlieb
add populate_datasets hook to migration
3992909
@avrohomgottlieb
call data migration functions, improve reversal logic
9987862
@avrohomgottlieb
remove unnecessary reverse function, fix triggers error
51402e5
@avrohomgottlieb
make ccdl name ccdl dataset attr non nullable
21d61c8
@avrohomgottlieb
add test_ccdl_dataset tests, update expected values, readme file, and…
42b2b3c 
… other references
@avrohomgottlieb
add test_user_dataset tests and references
635a8bf
@avrohomgottlieb
add test_dataset_abcc tests and references
a89b54f
@avrohomgottlieb
add type hints to readme file
d51b080
@avrohomgottlieb
update create_ccdl_datasets and computed_file references
d4a138f
@avrohomgottlieb
add generic foreign key and generic relation for dataset jobs, add ne…
560877b 
…w migration and update old migration accordingly
@avrohomgottlieb
add dataset validation to job model, update references
2a5a322
@avrohomgottlieb
rename dataset_id to dataset_object_id in generic relation
757797d
@avrohomgottlieb
update references in test job
1e2dbd0
@avrohomgottlieb
add test which asserts that dataset attr is subtype of DatasetABC
7a117cf
@avrohomgottlieb
update references in remaining tests
4a5fede
@avrohomgottlieb
rename files - ccdl to ccdl_dataset, user to user_dataset
622ed53
@avrohomgottlieb
move regenerated_from attr from datasetabc to user_dataset
d2cdd6b
@avrohomgottlieb
add download_filename and download_url defaults to datasetabc, remove…
b30e55a 
… from user_dataset
@avrohomgottlieb
rename ccdl dataset methods
036fd2e
@avrohomgottlieb
remove foreign key relationship between job and dataset models
7ed6e3a
@avrohomgottlieb
add datasetabc type hints
e6d0650
@avrohomgottlieb
add fallbacks for batch job queue and definition in JobFactory
ab9fbb8
@avrohomgottlieb
update expected_values
e034f1a
avrohomgottlieb and others added 17 commits January 22, 2026 12:15
@avrohomgottlieb
move dataset population run python logic from 0080 to 0081
1abb095
@avrohomgottlieb
update apply and reverse dataset job functions
d211b57
@avrohomgottlieb
fix datasets population reverse function
7488520
@avrohomgottlieb
correct assignment logic in apply_dataset_jobs function
b64630a
@avrohomgottlieb
set dataset_content_type field on delete to SET_NULL
55e3c19
@avrohomgottlieb
update error validation error message
ac6118b
@avrohomgottlieb
add custom job queryset and manager to handle bulk job dataset operat…
194b9f5 
…ions
@avrohomgottlieb
update ccdl dataset serializer and view
336519f
@avrohomgottlieb
update ccdl dataset serializer and view tests
b293777
@avrohomgottlieb
update user dataset serializer and dataset view
63e0ad1
@avrohomgottlieb
update tests, further update view
503596e
@avrohomgottlieb
split apply and reverse dataset functions by concrete class
e1c4306
@avrohomgottlieb
replace assignment of isCCDL var with ccdl_name attr in exchange for …
86c5d64 
…no longer valid is_ccdl attr
@avrohomgottlieb
remove start attr from CCDLDatasetSerializer
7c940d5
@avrohomgottlieb
remove email attr from CCDLDatasetSerializer
55e7496
@avrohomgottlieb
reduce queries in apply methods
2c56d5e
@avrohomgottlieb
Merge pull request #1782 from AlexsLemonade/dev
99e689a 
Merge dev into feature/dataset-abc
@avrohomgottlieb
Merge pull request #1769 from AlexsLemonade/avrohom/1714-dataset-abc-…
98a1a39 
…update-serializers-and-views

DatasetABC - Update Serializers and Views
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidsmejia davidsmejia Awaiting requested review from davidsmejia davidsmejia will be requested when the pull request is marked ready for review davidsmejia is a code owner

@nozomione nozomione Awaiting requested review from nozomione nozomione will be requested when the pull request is marked ready for review nozomione is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@avrohomgottlieb

Comments