Disable 'Merge into 1 object' option on View/Edit Samples page based on Selected Sample Count#1805
Open
Disable 'Merge into 1 object' option on View/Edit Samples page based on Selected Sample Count#1805
Conversation
…only if all samples have been selected in the table or all project samples have been added to My Dataset on the View/Edit Samples page
nozomione
changed the title
davidsmejia
reviewed
Feb 11, 2026
| // Enable the include merge checkbox only if: | ||
| // - All project samples in the table are selected | ||
| // - All project samples have been added to myDataset | ||
| const [enableMergeCheckBox, setEnableMergeCheckBox] = useState(false) |
Contributor
There was a problem hiding this comment.
Lets rename this to describe what information it is capturing. Since this variable is only used for disabling the button
Member
Author
There was a problem hiding this comment.
🗒️ Renamed to allSingleSamplesSelected.
I've also uncheck the include merge checkbox when any single-cell sample is deselected in the table, in case the option was previously selected.
…lected, and uncheck the include merge option (in case if it was previosuly selected) if any single-cell sample is deselected, improve the comments
Member
Author
|
I've applied the feedback, and this PR is ready for another look. Thank you, David! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #1722
@dvenprasad See the latest UI here. Thank you!
Purpose/Implementation Notes
I've disabled the
Merge single-cell samples into 1 objectoption on the View/Edit Samples page, except under the following conditions:Types of changes
Functional tests
N/A
Checklist
Screenshots
N/A