Don't flash the empty dataset page when user triggers the download#1836
Open
Don't flash the empty dataset page when user triggers the download#1836
Conversation
…r upon dataset processing, to prevent the empty My Dataset UI flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #1809
Purpose/Implementation Notes
I've updated the UI to display a loader before the redirect during the download processing to prevent the empty dataset UI flash.
@dvenprasad, See the latest UI here. Thank you!
Changes include:
redirectingstate topages/download/indexonRedirectingtoDatasetProcessModal, which will be set upon dataset processing submissionTypes of changes
Functional tests
N/A
Checklist
Screenshots
N/A