Skip to content

Don't flash the empty dataset page when user triggers the download#1836

Open
nozomione wants to merge 1 commit intodevfrom
nozomione/1809-prevent-empty-ui-flash-upon-processing
Open

Don't flash the empty dataset page when user triggers the download#1836
nozomione wants to merge 1 commit intodevfrom
nozomione/1809-prevent-empty-ui-flash-upon-processing

Conversation

@nozomione
Copy link
Member

Issue Number

Closes #1809

Purpose/Implementation Notes

I've updated the UI to display a loader before the redirect during the download processing to prevent the empty dataset UI flash.

@dvenprasad, See the latest UI here. Thank you!

Changes include:

  • Added a new state redirecting state to pages/download/index
  • Add a new prop onRedirecting to DatasetProcessModal, which will be set upon dataset processing submission

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactor (addresses code organization and design mentioned in corresponding issue)

Functional tests

N/A

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

N/A

…r upon dataset processing, to prevent the empty My Dataset UI flash
Copy link
Member

@dvenprasad dvenprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱 🐱 🐱
Looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't flash the empty dataset page when user triggers the download

2 participants

Comments