Skip to content

Conversation

kunzaatko
Copy link

This is not yet fully ready for use since the selected item is not visible correctly with the groups. This has to be
modified. The analogous groups from nvim_cmp are added in blink_cmp which should serve as a baseline.

It would be best to merge this and add an issue for finishing it since I am not able to dedicate any more time to this.

@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Apr 1, 2025
@AlexvZyl
Copy link
Owner

AlexvZyl commented Apr 1, 2025

Thanks for the PR :) Could you please just add a screenshot?

@DOD-101
Copy link
Collaborator

DOD-101 commented Apr 24, 2025

I've taken this and created the appropriate highlights, mostly based off of nvim_cmp's. I have left the ones related to the borders as ??? since they overlap with #174. If other than that the changes are approved then I'll remove those for now, get this PR merged and then deal with it in #174.

@DOD-101 DOD-101 requested a review from 5-pebbles April 24, 2025 18:58
@DOD-101 DOD-101 changed the title feat(integrations): blink_cmp integration copied from nvim_cmp feat(integrations): blink_cmp integration Apr 25, 2025
Copy link
Collaborator

@5-pebbles 5-pebbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature, request or suggestion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants