Add env and volume information in MPS situation. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contributions! @Sakuralbj Could you please add the guide and samples for others to understand the how to use it? Thanks. |
cheyang
requested changes
Jul 18, 2019
pkg/gpu/nvidia/allocate.go
Outdated
| }, | ||
| } | ||
| if m.mps { | ||
| response.Envs[EnvPercentage] = fmt.Sprintf("%d", 100*podReqGPU/getGPUMemory()) |
There was a problem hiding this comment.
May I ask if there is the only change for MPS support? I guess the volume mount(/tmp/mps) should be also added.
Btw, I think it should be 100*containerReqGPU/getGPUMemory() instead of 100*podReqGPU/getGPUMemory().
pkg/gpu/nvidia/const.go
Outdated
| EnvResourceByDev = "ALIYUN_COM_GPU_MEM_DEV" | ||
| EnvAssignedFlag = "ALIYUN_COM_GPU_MEM_ASSIGNED" | ||
| EnvResourceAssumeTime = "ALIYUN_COM_GPU_MEM_ASSUME_TIME" | ||
| EnvPercentage = "CUDA_MPS_ACTIVE_THREAD_PERCENTAGE" |
There was a problem hiding this comment.
I suggest it should be EnvMPSActiveThreadPercentage.
Signed-off-by: 630445639 <[email protected]>
Sakuralbj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 630445639 [email protected]