requirements.txt lockfile for accessible reproducible environements #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current README instructions ignore the
pdm.lockfile and install frompyproject.toml, which does not create reproducible environments. We may not expect all users to havepdm, though.Changes
pdm.locktorequirements.txtformat, and update the instructions to use it.requirements.txtis up to date with thepdm.lockand that thepdm.lockis up to date with thepyproject.toml.Testing
python -m venv venv,source venv/bin/activate, andpip install -r requirements.txt, but didn't run any code in that new environment.pdm.lockand now succeed