sort options lists and editable fields lists alphabetically #161
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements alphabetical sorting for both the editable fields list and recipe dropdown options to improve consistency and readability across the application.
Key Changes:
- Added
sortByutility from lodash-es to sort lists alphabetically - Applied sorting to editable fields returned from Firebase by the "name" property
- Applied sorting to dropdown options by the "label" property
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/firebase.ts | Sorts editable fields list alphabetically by name before returning from getEditableFieldsList |
| src/components/Dropdown/index.tsx | Sorts recipe dropdown options alphabetically by label before rendering in Select component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meganrm
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sorting the editable fields list and the recipe dropdown to be in alphabetical order.
It's a tiny change, but Thao had asked for it and it's nice that now the recipes that have the same editable fields will have them rendered consistently in the same order. Also this makes the multiple spheres editable fields easier to read.