Skip to content

Handle zero-index hits in utils #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle zero-index hits in utils #1655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29a6455
fix utils position detection
anandgupta42 May 17, 2025
432515f
Merge branch 'master' into auto-coding-agent/update-get-start-and-end…
anandgupta42 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion altimate_packages/altimate/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def sql_parse_errors(sql: str, dialect: str):

def get_start_and_end_position(sql: str, invalid_string: str):
start, end, num_occurences = find_single_occurrence_indices(sql, invalid_string)
if start and end:
if start is not None and end is not None:
return (
list(get_line_and_column_from_position(sql, start)),
list(get_line_and_column_from_position(sql, end)),
Expand Down
15 changes: 15 additions & 0 deletions altimate_packages/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import sys
import unittest
sys.path.insert(0, 'altimate_packages')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider avoiding manual sys.path insertion; setting PYTHONPATH or using proper package installation can improve test reliability.

from altimate.utils import get_start_and_end_position

class TestGetStartEndPosition(unittest.TestCase):
def test_invalid_token_at_beginning(self):
sql = "invalid_token SELECT * FROM table"
start, end, count = get_start_and_end_position(sql, "invalid_token")
self.assertEqual(start, [0, 1])
self.assertEqual(end, [0, len("invalid_token") + 1])
self.assertEqual(count, 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case, doesn't test new behavior.


if __name__ == "__main__":
unittest.main()
Loading