Open
Conversation
### 인적사항 학번: 2376320 이름: 홍채민 ### 과제제출 기존 제출: 1063, 1476, 11723 추가 제출: </br>
SYEON10
reviewed
Mar 15, 2025
04_브루트포스/필수/1063.cpp
Outdated
Comment on lines
+6
to
+8
There was a problem hiding this comment.
P2. 사전에 명령과 이동 방향에 대해 정의하신 점 아주 좋습니다! 그런데, 이 아이들을 묶어서 정의하면 더 좋지 않을까요? key-value 자료구조를 이용하시면 이동 방향을 8번 돌면서 검사하는 로직 없이도 깔끔하게 이동 기능을 구현할 수 있습니다!
04_브루트포스/필수/1063.cpp
Outdated
Comment on lines
+40
to
+44
There was a problem hiding this comment.
바로 킹의 위치를 옮기지 않고 새로운 위치를 먼저 확인하는 점 좋습니다!
zzangss
reviewed
Mar 16, 2025
zzangss
left a comment
zzangss
left a comment
There was a problem hiding this comment.
[1476번 코드리뷰 완료]
P3: 문제 너무 잘 풀어주셨습니다! 짧은 코멘트 남겨드렸으니 참고하시면 좋겠습니다. 이번 주도 수고 많으셨어요:)
04_브루트포스/필수/1476.cpp
Outdated
Comment on lines
+9
to
+16
There was a problem hiding this comment.
이 부분을 함수로 빼면 어떨까요? main 함수가 간결해져 코드 가독성과 재사용에 도움이 될 거 같습니다!
s0ye0ve
approved these changes
Mar 18, 2025
s0ye0ve
left a comment
s0ye0ve
left a comment
There was a problem hiding this comment.
[11723번 코드리뷰 완료]
11723(P3)
안녕하세요! 각 기능 모두 비트마스킹을 이용하여 잘 구현해주셨습니다. 짧은 코멘트 남겨드렸으니 확인 부탁드립니다. 수고 많으셨습니다! 🥰
04_브루트포스/필수/11723.cpp
Outdated
There was a problem hiding this comment.
main 함수에서는 입력, 출력 정도만 수행하고 각 기능을 함수로 분리해주면 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
인적사항
학번: 2376320
이름: 홍채민
과제제출
기존 제출: 1063, 1476, 11723
추가 제출: